Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"

2016-02-01 Thread Junio C Hamano
Michael Blume writes: > Maybe this isn't important given that it looks like the patch is going > to be rewritten, but I have > > stash.c:43:18: warning: incompatible pointer types assigning to 'const > char *const *' from 'const char *'; take the address with & > [-Wincompatible-pointer-types] >

Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"

2016-02-01 Thread Michael Blume
On Fri, Jan 29, 2016 at 11:58 AM, Junio C Hamano wrote: > Matthias Aßhauer writes: > > [administrivia: please wrap your lines to reasonable lengths] > >>> Honestly, I had high hopes after seeing the "we are rewriting it >>> in C" but I am not enthused after seeing this. I was hoping that >>> the

Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"

2016-01-29 Thread Junio C Hamano
Matthias Aßhauer writes: [administrivia: please wrap your lines to reasonable lengths] >> Honestly, I had high hopes after seeing the "we are rewriting it >> in C" but I am not enthused after seeing this. I was hoping that >> the rewritten version would do this all in-core, by calling these >>

AW: [PATCH 1/2] stash--helper: implement "git stash--helper"

2016-01-29 Thread Matthias Aßhauer
> Hmph, why not have everything inside builtin/stash--helper.c? I do not quite > see a point of having the other two "library-ish" looking files. > > Also I personally feel that it would be easier to review when these two > patches are squashed into one. I had to go back and forth while readin