Re: [git-multimail] smtplib, check certificate

2016-04-24 Thread Simon Pontié
Le 22/04/2016 08:41, Michael Haggerty a écrit : > I hate that we even have to worry about this stuff, but > graingert/secure-smtplib looks to be GPLv3, whereas git-multimail is > GPLv2 (like the Git project and Linux); *not* "GPLv2 or later". So if > "inspired" means "incorporated copyrightable co

Re: [git-multimail] smtplib, check certificate

2016-04-24 Thread Simon Pontié
Le 22/04/2016 08:05, Matthieu Moy a écrit : > Hi, and thanks for the patch. Hi. Thanks for your tool, it is very useful! > Please, add your sign-off and a proper commit message to your patch, > see: Done, I also signed my commit via PGP. > I'm OK with patches by email, but you may prefer usin

Re: [git-multimail] smtplib, check certificate

2016-04-21 Thread Michael Haggerty
On 04/22/2016 08:05 AM, Matthieu Moy wrote: > Simon P writes: > > This patch is inspired from > > > > https://github.com/graingert/secure-smtplib/blob/master/src/secure_smtplib/__init__.py > > Please, add your sign-off and a proper commit message to your patch, > see: > > https://github.com/git

Re: [git-multimail] smtplib, check certificate

2016-04-21 Thread Matthieu Moy
Simon P writes: > Hi, Hi, and thanks for the patch. Please, add your sign-off and a proper commit message to your patch, see: https://github.com/git-multimail/git-multimail/blob/master/CONTRIBUTING.rst I'm OK with patches by email, but you may prefer using a pull-request (among other things,

[git-multimail] smtplib, check certificate

2016-04-21 Thread Simon P
Hi, It seems that smtplib doesn't check if a certificate is valid (signed by a trusted CA). For my personal usage, I patched the starttls code in git-multimail: only for starttls with smtplib. This patch is inspired from https://github.com/graingert/secure-smtplib/blob/master/src/secure_smtplib