Re: [RFCv2 10/16] transport: connect_setup appends protocol version number

Stefan Beller writes: >> Hmph, so everybody else thinks it is interacting with 'upload-pack', >> and this is the only function that knows it is actually talking with >> 'upload-pack-2'? > > Yes. >> >> I am wondering why there isn't a separate helper function that >> munges data->options.{uploadpa

Re: [RFCv2 10/16] transport: connect_setup appends protocol version number

On Tue, Jun 2, 2015 at 2:37 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Signed-off-by: Stefan Beller >> --- >> >> Notes: >> name it to_free >> >> transport.c | 17 +++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/transport.c b/transport.c >

Re: [RFCv2 10/16] transport: connect_setup appends protocol version number

Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > > Notes: > name it to_free > > transport.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/transport.c b/transport.c > index 651f0ac..b49fc60 100644 > --- a/transport.c > +++ b/transport

Re: [RFCv2 10/16] transport: connect_setup appends protocol version number

On Tue, Jun 2, 2015 at 2:58 AM, Duy Nguyen wrote: > On Tue, Jun 2, 2015 at 7:02 AM, Stefan Beller wrote: >> Signed-off-by: Stefan Beller >> --- >> >> Notes: >> name it to_free >> >> transport.c | 17 +++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/tr

Re: [RFCv2 10/16] transport: connect_setup appends protocol version number

On Tue, Jun 2, 2015 at 7:02 AM, Stefan Beller wrote: > Signed-off-by: Stefan Beller > --- > > Notes: > name it to_free > > transport.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/transport.c b/transport.c > index 651f0ac..b49fc60 100644 > --- a

[RFCv2 10/16] transport: connect_setup appends protocol version number

Signed-off-by: Stefan Beller --- Notes: name it to_free transport.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/transport.c b/transport.c index 651f0ac..b49fc60 100644 --- a/transport.c +++ b/transport.c @@ -496,15 +496,28 @@ static int set_git_opt