Re: [RFCv2 03/16] connect: rewrite feature parsing to work on string_list

2015-06-02 Thread Junio C Hamano
Stefan Beller writes: > Signed-off-by: Stefan Beller > --- The change in 2/16 to extract something into a helper was sort-of guessable without any comment (i.e. perhaps it will gain new callers in later patches), but a change like this needs to hint why this is a good thing to do, I would think

[RFCv2 03/16] connect: rewrite feature parsing to work on string_list

2015-06-01 Thread Stefan Beller
Signed-off-by: Stefan Beller --- builtin/receive-pack.c | 13 + connect.c | 79 ++ connect.h | 2 +- upload-pack.c | 11 +-- 4 files changed, 51 insertions(+), 54 deletions(-) diff --git a/builtin/rec