Re: [RFC WIP PATCH v8 11/13] rebase: eliminate side-effects from can_fast_forward()

2019-05-17 Thread Johannes Schindelin
Hi Ævar, On Wed, 8 May 2019, Ævar Arnfjörð Bjarmason wrote: > The can_fast_forward() function is potentially much more expensive > than is_interactive() since it e.g. might need to call > is_linear_history(). > > So reversing the two looks like an obvious improvement, but doing so > reveals a pre

[RFC WIP PATCH v8 11/13] rebase: eliminate side-effects from can_fast_forward()

2019-05-07 Thread Ævar Arnfjörð Bjarmason
The can_fast_forward() function is potentially much more expensive than is_interactive() since it e.g. might need to call is_linear_history(). So reversing the two looks like an obvious improvement, but doing so reveals a previously hidden caveat: We need the can_fast_forward() function to populat