Re: [RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-10-03 Thread Junio C Hamano
Carlo Arenas writes: > or we could drop the current branch in pu and start again from scratch > now that all of the required dependencies had been merged. That would be the cleanest from my point of view. Thanks, both.

Re: [RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-10-03 Thread Johannes Schindelin
Hi Carlo, On Thu, 3 Oct 2019, Carlo Arenas wrote: > On Thu, Oct 3, 2019 at 1:09 AM Johannes Schindelin > wrote: > > I still need > > https://github.com/git-for-windows/git/commit/719beb813e4f27f090696ce583df3e5f3c480545 > > and > > https://github.com/git-for-windows/git/commit/3369c322bbd95820b9

Re: [RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-10-03 Thread Carlo Arenas
On Thu, Oct 3, 2019 at 1:09 AM Johannes Schindelin wrote: > I still need > https://github.com/git-for-windows/git/commit/719beb813e4f27f090696ce583df3e5f3c480545 > and > https://github.com/git-for-windows/git/commit/3369c322bbd95820b971701fef7db44b26dd826f > to fix that part in Git for Windows' `s

Re: [RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-10-03 Thread Johannes Schindelin
Hi Junio, On Thu, 3 Oct 2019, Junio C Hamano wrote: > Carlo Arenas writes: > > > On Tue, Aug 27, 2019 at 2:07 AM Johannes Schindelin > > wrote: > >> > >> Unfortunately, this is _still_ incorrect. > > ... > > Just to clarify, I think my patch accounts for that (haven't tested > > that assumption

Re: [RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-10-02 Thread Junio C Hamano
Carlo Arenas writes: > On Tue, Aug 27, 2019 at 2:07 AM Johannes Schindelin > wrote: >> >> Unfortunately, this is _still_ incorrect. > ... > Just to clarify, I think my patch accounts for that (haven't tested > that assumption, but will do now that I have a windows box, probably > even with mi-al

Re: [RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-08-27 Thread Carlo Arenas
On Tue, Aug 27, 2019 at 2:07 AM Johannes Schindelin wrote: > > Unfortunately, this is _still_ incorrect. I know, and that is why we worked out a v6 RC with Rene than then was pushed to github[0] and validated to work thanks to your integration as detailed in [1], I never got to send an update to

Re: [RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-08-27 Thread Johannes Schindelin
Hi Carlo, On Thu, 8 Aug 2019, Carlo Marcelo Arenas Belón wrote: > 94da9193a6 (grep: add support for PCRE v2, 2017-06-01) didn't include > a way to override the system allocator, and so it is incompatible with > USE_NED_ALLOCATOR. The problem was made visible when an attempt to > avoid a leak in

[RFC PATCH v5 2/3] grep: make PCRE2 aware of custom allocator

2019-08-08 Thread Carlo Marcelo Arenas Belón
94da9193a6 (grep: add support for PCRE v2, 2017-06-01) didn't include a way to override the system allocator, and so it is incompatible with USE_NED_ALLOCATOR. The problem was made visible when an attempt to avoid a leak in a data structure that is created by the library was passed to NED's free f