Re: [RFC PATCH v3] grep: treat PCRE2 jit compilation memory error as non fatal

2019-08-05 Thread Junio C Hamano
Carlo Arenas writes: > * code is suspiciously similar to one[2] that was rejected, but > hopefully commit message is better > ... > [2] https://public-inbox.org/git/20181209230024.43444-3-care...@gmail.com/ I do not recall ever rejecting that one. It did not come with a good proposed log messag

Re: [RFC PATCH v3] grep: treat PCRE2 jit compilation memory error as non fatal

2019-08-04 Thread Carlo Arenas
PROs: * it works (only for PCRE2) and tested in OpenBSD, NetBSD, macOS, Linux (Debian) * it applies everywhere (even pu) without conflicts * it doesn't introduce any regressions in tests (tested in Debian with SElinux in enforcing mode) * it is simple CONs: * HardenedBSD still segfaults (bugfix pr

[RFC PATCH v3] grep: treat PCRE2 jit compilation memory error as non fatal

2019-08-03 Thread Carlo Marcelo Arenas Belón
94da9193a6 (grep: add support for PCRE v2, 2017-06-01) uses the JIT fast path unless JIT support has not been compiled in the linked library. Starting from 10.23 of PCRE2, pcre2grep ignores any errors from pcre2_jit_cpmpile as a workaround for their bug1749[1] and we should do too, so that the int