Re: [RFC PATCH v2 2/5] branch: re-order function arguments to group related arguments

2017-10-23 Thread Stefan Beller
On Fri, Oct 20, 2017 at 7:56 PM, Kaartic Sivaraam wrote: > On Fri, 2017-10-20 at 14:50 -0700, Stefan Beller wrote: >> On Mon, Sep 25, 2017 at 1:20 AM, Kaartic Sivaraam >> wrote: >> > The ad-hoc patches to add new arguments to a function when needed >> > resulted in the related arguments not being

Re: [RFC PATCH v2 2/5] branch: re-order function arguments to group related arguments

2017-10-20 Thread Kaartic Sivaraam
On Fri, 2017-10-20 at 14:50 -0700, Stefan Beller wrote: > On Mon, Sep 25, 2017 at 1:20 AM, Kaartic Sivaraam > wrote: > > The ad-hoc patches to add new arguments to a function when needed > > resulted in the related arguments not being close to each other. > > This misleads the person reading the c

Re: [RFC PATCH v2 2/5] branch: re-order function arguments to group related arguments

2017-10-20 Thread Stefan Beller
On Mon, Sep 25, 2017 at 1:20 AM, Kaartic Sivaraam wrote: > The ad-hoc patches to add new arguments to a function when needed > resulted in the related arguments not being close to each other. > This misleads the person reading the code to believe that there isn't > much relation between those argu

[RFC PATCH v2 2/5] branch: re-order function arguments to group related arguments

2017-09-25 Thread Kaartic Sivaraam
The ad-hoc patches to add new arguments to a function when needed resulted in the related arguments not being close to each other. This misleads the person reading the code to believe that there isn't much relation between those arguments while it's not the case. So, re-order the arguments to keep