Re: [RFC PATCH v2 10/13] walken: add unfiltered object walk from HEAD

2019-07-01 Thread Emily Shaffer
On Thu, Jun 27, 2019 at 08:48:31PM -0400, Eric Sunshine wrote: > On Thu, Jun 27, 2019 at 6:31 PM Emily Shaffer wrote: > > On Thu, Jun 27, 2019 at 01:37:58AM -0400, Eric Sunshine wrote: > > > Don't localize the die() message via _() here or in the preceding > > > OBJ_COMMIT case. > > > > I'm a litt

Re: [RFC PATCH v2 10/13] walken: add unfiltered object walk from HEAD

2019-06-27 Thread Eric Sunshine
On Thu, Jun 27, 2019 at 6:31 PM Emily Shaffer wrote: > On Thu, Jun 27, 2019 at 01:37:58AM -0400, Eric Sunshine wrote: > > Don't localize the die() message via _() here or in the preceding > > OBJ_COMMIT case. > > I'm a little surprised by that. Is it because die() is expected to only > be seen by

Re: [RFC PATCH v2 10/13] walken: add unfiltered object walk from HEAD

2019-06-27 Thread Emily Shaffer
On Thu, Jun 27, 2019 at 01:37:58AM -0400, Eric Sunshine wrote: > On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote: > > Provide a demonstration of a revision walk which traverses all types of > > object, not just commits. This type of revision walk is used for > > operations such as creating pac

Re: [RFC PATCH v2 10/13] walken: add unfiltered object walk from HEAD

2019-06-26 Thread Eric Sunshine
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote: > Provide a demonstration of a revision walk which traverses all types of > object, not just commits. This type of revision walk is used for > operations such as creating packfiles and performing fetches or clones, > so it's useful to teach new

[RFC PATCH v2 10/13] walken: add unfiltered object walk from HEAD

2019-06-26 Thread Emily Shaffer
Provide a demonstration of a revision walk which traverses all types of object, not just commits. This type of revision walk is used for operations such as creating packfiles and performing fetches or clones, so it's useful to teach new developers how it works. For starters, only demonstrate the un