Re: [RFC PATCH v2 1/4] object: remove "used" field from struct object

2017-07-20 Thread Junio C Hamano
Jonathan Tan writes: > The "used" field in struct object is only used by builtin/fsck. Remove > that field and modify builtin/fsck to use a flag instead. > > Signed-off-by: Jonathan Tan > --- > builtin/fsck.c | 24 ++-- > object.c | 1 - > object.h | 2 +- > 3

Re: [RFC PATCH v2 1/4] object: remove "used" field from struct object

2017-07-20 Thread Ben Peart
On 7/19/2017 8:55 PM, Jonathan Tan wrote: On Wed, 19 Jul 2017 17:36:39 -0700 Stefan Beller wrote: On Wed, Jul 19, 2017 at 5:21 PM, Jonathan Tan wrote: The "used" field in struct object is only used by builtin/fsck. Remove that field and modify builtin/fsck to use a flag instead. The patc

Re: [RFC PATCH v2 1/4] object: remove "used" field from struct object

2017-07-19 Thread Jonathan Tan
On Wed, 19 Jul 2017 17:36:39 -0700 Stefan Beller wrote: > On Wed, Jul 19, 2017 at 5:21 PM, Jonathan Tan > wrote: > > The "used" field in struct object is only used by builtin/fsck. Remove > > that field and modify builtin/fsck to use a flag instead. > > The patch looks good to me (I would even

Re: [RFC PATCH v2 1/4] object: remove "used" field from struct object

2017-07-19 Thread Stefan Beller
On Wed, Jul 19, 2017 at 5:21 PM, Jonathan Tan wrote: > The "used" field in struct object is only used by builtin/fsck. Remove > that field and modify builtin/fsck to use a flag instead. The patch looks good to me (I would even claim this could go in as an independent cleanup, not tied to the RFCi

[RFC PATCH v2 1/4] object: remove "used" field from struct object

2017-07-19 Thread Jonathan Tan
The "used" field in struct object is only used by builtin/fsck. Remove that field and modify builtin/fsck to use a flag instead. Signed-off-by: Jonathan Tan --- builtin/fsck.c | 24 ++-- object.c | 1 - object.h | 2 +- 3 files changed, 15 insertions(+), 12 dele