Re: [RFC PATCH 6/6] commit-reach: fix first-parent heuristic

2018-10-11 Thread Derrick Stolee
On 10/10/2018 9:50 PM, Jonathan Nieder wrote: Hi, Derrick Stolee wrote: commit-reach.c| 4 +++- t/t6600-test-reach.sh | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) I like this testing technique, and the test passes for me. Except: if I put CC = cc -m32

Re: [RFC PATCH 6/6] commit-reach: fix first-parent heuristic

2018-10-10 Thread Jonathan Nieder
Hi, Derrick Stolee wrote: > commit-reach.c| 4 +++- > t/t6600-test-reach.sh | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) I like this testing technique, and the test passes for me. Except: if I put CC = cc -m32 NO_OPENSSL = YesPlease NO_CURL = YesP

[RFC PATCH 6/6] commit-reach: fix first-parent heuristic

2018-09-06 Thread Derrick Stolee
The algorithm in can_all_from_reach_with_flags() performs a depth- first-search, terminated by generation number, intending to use a hueristic that "important" commits are found in the first-parent history. This heuristic is valuable in scenarios like fetch negotiation. However, there is a problem