Re: [RFC PATCH 3/3] trace2: add a schema validator for trace2 events

2019-06-27 Thread Jeff Hostetler
On 6/21/2019 7:53 AM, Jakub Narebski wrote: Josh Steadmon writes: On 2019.06.12 15:28, Ævar Arnfjörð Bjarmason wrote: On Wed, Jun 12 2019, Josh Steadmon wrote: trace_schema_validator can be used to verify that trace2 event output conforms to the expectations set by the API documentation a

Re: [RFC PATCH 3/3] trace2: add a schema validator for trace2 events

2019-06-21 Thread Jakub Narebski
Josh Steadmon writes: > On 2019.06.12 15:28, Ævar Arnfjörð Bjarmason wrote: >> On Wed, Jun 12 2019, Josh Steadmon wrote: >> >>> trace_schema_validator can be used to verify that trace2 event output >>> conforms to the expectations set by the API documentation and codified >>> in event_schema.jso

Re: [RFC PATCH 3/3] trace2: add a schema validator for trace2 events

2019-06-20 Thread Josh Steadmon
On 2019.06.12 15:18, Jeff King wrote: > On Wed, Jun 12, 2019 at 09:23:41AM -0700, Josh Steadmon wrote: > > > The problem with the existing validators is that they expect each file to > > be a > > complete JSON entity, whereas the trace output is one object per line. You > > can > > of course loo

Re: [RFC PATCH 3/3] trace2: add a schema validator for trace2 events

2019-06-12 Thread Jeff King
On Wed, Jun 12, 2019 at 09:23:41AM -0700, Josh Steadmon wrote: > The problem with the existing validators is that they expect each file to be a > complete JSON entity, whereas the trace output is one object per line. You can > of course loop over the lines in a shell script, but in my testing this

Re: [RFC PATCH 3/3] trace2: add a schema validator for trace2 events

2019-06-12 Thread Josh Steadmon
On 2019.06.12 15:28, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Jun 12 2019, Josh Steadmon wrote: > > > trace_schema_validator can be used to verify that trace2 event output > > conforms to the expectations set by the API documentation and codified > > in event_schema.json (or strict_schema.json)

Re: [RFC PATCH 3/3] trace2: add a schema validator for trace2 events

2019-06-12 Thread Ævar Arnfjörð Bjarmason
On Wed, Jun 12 2019, Josh Steadmon wrote: > trace_schema_validator can be used to verify that trace2 event output > conforms to the expectations set by the API documentation and codified > in event_schema.json (or strict_schema.json). This allows us to build a > regression test to verify that tr

[RFC PATCH 3/3] trace2: add a schema validator for trace2 events

2019-06-11 Thread Josh Steadmon
trace_schema_validator can be used to verify that trace2 event output conforms to the expectations set by the API documentation and codified in event_schema.json (or strict_schema.json). This allows us to build a regression test to verify that trace2 output does not change unexpectedly. Signed-off