Re: [RFC PATCH 3/2] vreportf: add prefix to each line

2017-01-11 Thread Jeff King
On Wed, Jan 11, 2017 at 02:11:42PM -0800, Junio C Hamano wrote: > > It's actually kind of ugly. For instance, a failing test in > > t3600 now produces: > > > >error: the following files have staged content different from both the > >error: file and the HEAD: > >error: bar.txt > >

Re: [RFC PATCH 3/2] vreportf: add prefix to each line

2017-01-11 Thread Junio C Hamano
Jeff King writes: > On Wed, Jan 11, 2017 at 09:01:38AM -0500, Jeff King wrote: > >> [1/2]: Revert "vreportf: avoid intermediate buffer" >> [2/2]: vreport: sanitize ASCII control chars > > We've talked before about repeating the "error:" header for multi-line > messages. The reversion in patch

[RFC PATCH 3/2] vreportf: add prefix to each line

2017-01-11 Thread Jeff King
On Wed, Jan 11, 2017 at 09:01:38AM -0500, Jeff King wrote: > [1/2]: Revert "vreportf: avoid intermediate buffer" > [2/2]: vreport: sanitize ASCII control chars We've talked before about repeating the "error:" header for multi-line messages. The reversion in patch 1 makes this easy to play wit