Re: [RFC PATCH 2/3] sha1-array: support appending unsigned char hash

2017-07-19 Thread Stefan Beller
On Wed, Jul 19, 2017 at 4:56 PM, Jonathan Tan wrote: > On Tue, 11 Jul 2017 15:06:11 -0700 > Stefan Beller wrote: > >> On Tue, Jul 11, 2017 at 12:48 PM, Jonathan Tan >> wrote: >> > In a subsequent patch, sha1_file will need to append object names in the >> > form of "unsigned char *" to oid arra

Re: [RFC PATCH 2/3] sha1-array: support appending unsigned char hash

2017-07-19 Thread Jonathan Tan
On Tue, 11 Jul 2017 15:06:11 -0700 Stefan Beller wrote: > On Tue, Jul 11, 2017 at 12:48 PM, Jonathan Tan > wrote: > > In a subsequent patch, sha1_file will need to append object names in the > > form of "unsigned char *" to oid arrays. Teach sha1-array support for > > that. > > > > Signed-off-b

Re: [RFC PATCH 2/3] sha1-array: support appending unsigned char hash

2017-07-11 Thread Stefan Beller
On Tue, Jul 11, 2017 at 12:48 PM, Jonathan Tan wrote: > In a subsequent patch, sha1_file will need to append object names in the > form of "unsigned char *" to oid arrays. Teach sha1-array support for > that. > > Signed-off-by: Jonathan Tan This breaks the oid/sha1 barrier? I would have expecte

[RFC PATCH 2/3] sha1-array: support appending unsigned char hash

2017-07-11 Thread Jonathan Tan
In a subsequent patch, sha1_file will need to append object names in the form of "unsigned char *" to oid arrays. Teach sha1-array support for that. Signed-off-by: Jonathan Tan --- sha1-array.c | 7 +++ sha1-array.h | 1 + 2 files changed, 8 insertions(+) diff --git a/sha1-array.c b/sha1-ar