Re: [RFC PATCH 1/7] rebase -i: Make option handling in pick_one more flexible

2014-06-23 Thread Johannes Schindelin
Hi, On Sun, 22 Jun 2014, Fabian Ruch wrote: > On 06/20/2014 03:40 PM, Michael Haggerty wrote: > > On 06/19/2014 05:28 AM, Fabian Ruch wrote: > >> `pick_one` and `pick_one_preserving_merges` are wrappers around > >> `cherry-pick` in `rebase --interactive`. They take the hash of a commit > >> and b

Re: [RFC PATCH 1/7] rebase -i: Make option handling in pick_one more flexible

2014-06-22 Thread Fabian Ruch
Hi Junio, On 06/20/2014 09:53 PM, Junio C Hamano wrote: > Michael Haggerty writes: >>> pick_one () { >>> ff=--ff >>> + extra_args= >>> + while test $# -gt 0 >>> + do >>> + case "$1" in >>> + -n) >>> + ff= >>> + extra_args="$extra_

Re: [RFC PATCH 1/7] rebase -i: Make option handling in pick_one more flexible

2014-06-21 Thread Fabian Ruch
Hi Michael, On 06/20/2014 03:40 PM, Michael Haggerty wrote: > On 06/19/2014 05:28 AM, Fabian Ruch wrote: >> `pick_one` and `pick_one_preserving_merges` are wrappers around >> `cherry-pick` in `rebase --interactive`. They take the hash of a commit >> and build a `cherry-pick` command line that >> >

Re: [RFC PATCH 1/7] rebase -i: Make option handling in pick_one more flexible

2014-06-20 Thread Junio C Hamano
Michael Haggerty writes: >> pick_one () { >> ff=--ff >> +extra_args= >> +while test $# -gt 0 >> +do >> +case "$1" in >> +-n) >> +ff= >> +extra_args="$extra_args -n" >> +;; >> +-*) >>

Re: [RFC PATCH 1/7] rebase -i: Make option handling in pick_one more flexible

2014-06-20 Thread Michael Haggerty
On 06/19/2014 05:28 AM, Fabian Ruch wrote: > `pick_one` and `pick_one_preserving_merges` are wrappers around > `cherry-pick` in `rebase --interactive`. They take the hash of a commit > and build a `cherry-pick` command line that > > - respects the user-supplied merge options > - disables complai

[RFC PATCH 1/7] rebase -i: Make option handling in pick_one more flexible

2014-06-18 Thread Fabian Ruch
`pick_one` and `pick_one_preserving_merges` are wrappers around `cherry-pick` in `rebase --interactive`. They take the hash of a commit and build a `cherry-pick` command line that - respects the user-supplied merge options - disables complaints about empty commits - tries to fast-forward the re