Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-22 Thread Johannes Schindelin
Hi, On Mon, 21 Oct 2019, Denton Liu wrote: > Hi Johannes, > > On Mon, Oct 21, 2019 at 08:44:40PM +0200, Johannes Schindelin wrote: > > Hi Junio, > > > > On Fri, 18 Oct 2019, Junio C Hamano wrote: > > > > > Denton Liu writes: > > > > > > > There are many += lists in the Makefile and, over time, t

Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-22 Thread Junio C Hamano
Jeff King writes: >> ... >> I agree with you that it did correctly sort them in ASCII order. > > What's the purpose of sorting them, though? I thought it was less for > aesthetics and more to to keep lines deterministic (to avoid two > branches adding the same line in different places, thus causi

Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-21 Thread Jeff King
On Tue, Oct 22, 2019 at 04:49:19AM +0900, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> ... I do not particularly see this change (there may be similar > >> ones) desirable. I'd find it it be much more natural to sort > >> "commit-anything" after "commit", and that is true with or

Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-21 Thread Junio C Hamano
Johannes Schindelin writes: >> ... I do not particularly see this change (there may be similar >> ones) desirable. I'd find it it be much more natural to sort >> "commit-anything" after "commit", and that is true with or without >> the common extension ".o" added to these entries. >> >> In short

Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-21 Thread Denton Liu
Hi Johannes, On Mon, Oct 21, 2019 at 08:44:40PM +0200, Johannes Schindelin wrote: > Hi Junio, > > On Fri, 18 Oct 2019, Junio C Hamano wrote: > > > Denton Liu writes: > > > > > There are many += lists in the Makefile and, over time, they have gotten > > > slightly out of order, alphabetically. A

Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-21 Thread Johannes Schindelin
Hi Junio, On Fri, 18 Oct 2019, Junio C Hamano wrote: > Denton Liu writes: > > > There are many += lists in the Makefile and, over time, they have gotten > > slightly out of order, alphabetically. Alphabetically sort all += lists > > to bring them back in order. > > ... > > Hmm. I like the gener

Re: [RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-17 Thread Junio C Hamano
Denton Liu writes: > There are many += lists in the Makefile and, over time, they have gotten > slightly out of order, alphabetically. Alphabetically sort all += lists > to bring them back in order. > ... Hmm. I like the general thrust, but ... > LIB_OBJS += combine-diff.o > -LIB_OBJS += comm

[RFC PATCH 1/7] Makefile: alphabetically sort += lists

2019-10-16 Thread Denton Liu
There are many += lists in the Makefile and, over time, they have gotten slightly out of order, alphabetically. Alphabetically sort all += lists to bring them back in order. Signed-off-by: Denton Liu --- Makefile | 75 1 file changed, 38 i