Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-11 Thread Ævar Arnfjörð Bjarmason
On Tue, Dec 11 2018, Carlo Arenas wrote: > On Mon, Dec 10, 2018 at 12:24 AM Ævar Arnfjörð Bjarmason > wrote: >> On Mon, Dec 10 2018, brian m. carlson wrote: >> > Considering that some Linux users use PaX kernels with standard >> > distributions and that most BSD kernels can be custom-compiled w

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-11 Thread Carlo Arenas
On Mon, Dec 10, 2018 at 12:24 AM Ævar Arnfjörð Bjarmason wrote: > On Mon, Dec 10 2018, brian m. carlson wrote: > > Considering that some Linux users use PaX kernels with standard > > distributions and that most BSD kernels can be custom-compiled with a > > variety of options enabled or disabled, I

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-10 Thread Ævar Arnfjörð Bjarmason
On Mon, Dec 10 2018, brian m. carlson wrote: > On Mon, Dec 10, 2018 at 12:51:01AM +0100, Ævar Arnfjörð Bjarmason wrote: >> Obviously this & what you have in 2/2 needs to be fixed in some way. >> >> Is the issue on SELinux, OpenBSD, NetBSD etc. *how* PCRE is creating the >> the JIT'd code? I.e. p

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-09 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> @@ -32,14 +32,14 @@ all:: >> # USE_LIBPCRE is a synonym for USE_LIBPCRE2, define USE_LIBPCRE1 >> # instead if you'd like to use the legacy version 1 of the PCRE >> # library. Support for version 1 will likely be removed in some future >> -# release of Git, as

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-09 Thread Junio C Hamano
Carlo Marcelo Arenas Belón writes: > JIT support was added to 8.20 but the interface we rely on is only > enabled after 8.32 so try to make the message clearer. Could you add some word before 8.20 and 8.32 (e.g. "pcre library version 8.20", if that is what you are referring to, and if 8.32 is a

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-09 Thread Junio C Hamano
"brian m. carlson" writes: > Considering that some Linux users use PaX kernels with standard > distributions and that most BSD kernels can be custom-compiled with a > variety of options enabled or disabled, I think this is something we > should detect dynamically. > ... > My view is that JIT is a

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-09 Thread Carlo Arenas
On Sun, Dec 9, 2018 at 4:42 PM brian m. carlson wrote: > > On Mon, Dec 10, 2018 at 12:51:01AM +0100, Ævar Arnfjörð Bjarmason wrote: > > Obviously this & what you have in 2/2 needs to be fixed in some way. > > > > Is the issue on SELinux, OpenBSD, NetBSD etc. *how* PCRE is creating the > > the JIT'

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-09 Thread brian m. carlson
On Mon, Dec 10, 2018 at 12:51:01AM +0100, Ævar Arnfjörð Bjarmason wrote: > Obviously this & what you have in 2/2 needs to be fixed in some way. > > Is the issue on SELinux, OpenBSD, NetBSD etc. *how* PCRE is creating the > the JIT'd code? I.e. presumably Google Chrome's JIT engine, Java JIT and >

Re: [RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-09 Thread Ævar Arnfjörð Bjarmason
On Sun, Dec 09 2018, Carlo Marcelo Arenas Belón wrote: [+CC pcre-dev] > JIT support was added to 8.20 but the interface we rely on is only > enabled after 8.32 so try to make the message clearer. > > in systems where there are restrictions against creating executable > pages programatically (li

[RFC PATCH 1/2] grep: fallback to interpreter if JIT fails with pcre1

2018-12-09 Thread Carlo Marcelo Arenas Belón
JIT support was added to 8.20 but the interface we rely on is only enabled after 8.32 so try to make the message clearer. in systems where there are restrictions against creating executable pages programatically (like OpenBSD, NetBSD, macOS or seLinux) JIT will fail, resulting in a error message t