Re: [RFC PATCH 1/2] add a local copy of Mail::Address from CPAN

2018-01-05 Thread Ævar Arnfjörð Bjarmason
On Thu, Jan 04 2018, Matthieu Moy jotted: > I looked at the perl/Git/Error.pm wrapper, and ended up writting a > different, much simpler version. I'm not sure the same approach would > apply to Error.pm, but my straightforward version does the job for > Mail/Address.pm. Yeah, yours is much simpl

Re: [RFC PATCH 1/2] add a local copy of Mail::Address from CPAN

2018-01-04 Thread Eric Sunshine
On Thu, Jan 4, 2018 at 1:55 PM, Matthieu Moy wrote: > We used to have two versions of the email parsing code. Our > parse_mailboxes (in Git.pm), and Mail::Address which we used if > installed. Unfortunately, both versions have different sets of bugs, and > changing the behavior of git depending on

[RFC PATCH 1/2] add a local copy of Mail::Address from CPAN

2018-01-04 Thread Matthieu Moy
We used to have two versions of the email parsing code. Our parse_mailboxes (in Git.pm), and Mail::Address which we used if installed. Unfortunately, both versions have different sets of bugs, and changing the behavior of git depending on whether Mail::Address is installed was a bad idea. A first