Re: [RFC PATCH 1/2] Makefile: add check-headers target

2014-09-06 Thread David Aguilar
On Sat, Sep 06, 2014 at 07:58:09PM -0400, Jeff King wrote: > On Sat, Sep 06, 2014 at 03:57:39PM -0700, David Aguilar wrote: > > > > This checks all .h files in the top directory. Would it be better > > > to check all files in LIB_H instead? Or even all .h files in the > > > tree (using "git ls-f

Re: [RFC PATCH 1/2] Makefile: add check-headers target

2014-09-06 Thread Jeff King
On Sat, Sep 06, 2014 at 03:57:39PM -0700, David Aguilar wrote: > > This checks all .h files in the top directory. Would it be better > > to check all files in LIB_H instead? Or even all .h files in the > > tree (using "git ls-files '*.h'")? The latter might be difficult > > because some of the

Re: [RFC PATCH 1/2] Makefile: add check-headers target

2014-09-06 Thread David Aguilar
On Sat, Sep 06, 2014 at 11:20:32PM +0200, René Scharfe wrote: > Am 06.09.2014 um 21:20 schrieb David Aguilar: > >This allows us to ensure that each header can be included > >individually without needing to include other headers first. > > Sounds like a good objective. > > >Signed-off-by: David Ag

Re: [RFC PATCH 1/2] Makefile: add check-headers target

2014-09-06 Thread René Scharfe
Am 06.09.2014 um 21:20 schrieb David Aguilar: This allows us to ensure that each header can be included individually without needing to include other headers first. Sounds like a good objective. Signed-off-by: David Aguilar --- This patch demonstrates how to verify PATCH 2/2. Makefile

[RFC PATCH 1/2] Makefile: add check-headers target

2014-09-06 Thread David Aguilar
This allows us to ensure that each header can be included individually without needing to include other headers first. Signed-off-by: David Aguilar --- This patch demonstrates how to verify PATCH 2/2. Makefile | 6 ++ check-headers.sh | 26 ++ 2 files change