Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-31 Thread Johannes Schindelin
Hi, On Sun, 28 Jul 2019, Carlo Marcelo Arenas Belón wrote: > PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never > had one, forcing the use of JIT if -P was requested. > > After ed0479ce3d (Merge branch 'ab/no-kwset' into next, 2019-07-15) > the PCRE2 engine will be used more br

Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-30 Thread Carlo Arenas
On Mon, Jul 29, 2019 at 5:38 AM Ævar Arnfjörð Bjarmason wrote: > On Mon, Jul 29 2019, Carlo Arenas wrote: > > On Mon, Jul 29, 2019 at 1:55 AM Ævar Arnfjörð Bjarmason > > wrote: > >> > >> On Mon, Jul 29 2019, Carlo Marcelo Arenas Belón wrote: > >> > >> > PCRE1 allowed for a compile time flag to di

Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-29 Thread Ævar Arnfjörð Bjarmason
On Mon, Jul 29 2019, Carlo Arenas wrote: > On Mon, Jul 29, 2019 at 1:55 AM Ævar Arnfjörð Bjarmason > wrote: >> >> On Mon, Jul 29 2019, Carlo Marcelo Arenas Belón wrote: >> >> > PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never >> > had one, forcing the use of JIT if -P was r

Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-29 Thread Carlo Arenas
On Mon, Jul 29, 2019 at 1:55 AM Ævar Arnfjörð Bjarmason wrote: > > On Mon, Jul 29 2019, Carlo Marcelo Arenas Belón wrote: > > > PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never > > had one, forcing the use of JIT if -P was requested. > > What's that PCRE1 compile-time flag? N

Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-29 Thread Ævar Arnfjörð Bjarmason
On Mon, Jul 29 2019, Carlo Marcelo Arenas Belón wrote: > PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never > had one, forcing the use of JIT if -P was requested. What's that PCRE1 compile-time flag? > After ed0479ce3d (Merge branch 'ab/no-kwset' into next, 2019-07-15) > the

Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-28 Thread Carlo Arenas
On Sun, Jul 28, 2019 at 9:57 PM Junio C Hamano wrote: > > I am not sure I like a config-only knob like this, > though---shouldn't we have a command line knob to turn jit off > first, and then for those who gets tired of having to type it all > the time add the configuration to flip the default for

Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-28 Thread Junio C Hamano
Carlo Marcelo Arenas Belón writes: > PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never > had one, forcing the use of JIT if -P was requested. > > After ed0479ce3d (Merge branch 'ab/no-kwset' into next, 2019-07-15) > the PCRE2 engine will be used more broadly and therefore add

Re: [RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-28 Thread Carlo Arenas
On Sun, Jul 28, 2019 at 4:54 PM Carlo Marcelo Arenas Belón wrote: > @@ -125,6 +126,12 @@ int grep_config(const char *var, const char *value, void > *cb) > return 0; > } > > + if (!strcmp(var, "pcre.jit")) { > + int is_bool; > + opt->pcre_j

[RFC PATCH] grep: allow for run time disabling of JIT in PCRE

2019-07-28 Thread Carlo Marcelo Arenas Belón
PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never had one, forcing the use of JIT if -P was requested. After ed0479ce3d (Merge branch 'ab/no-kwset' into next, 2019-07-15) the PCRE2 engine will be used more broadly and therefore adding this knob will give users a fallback for si