Re: [RFC PATCH] gc --auto: don't lie about running in background on Windows

2016-05-07 Thread SZEDER Gábor
Quoting Junio C Hamano : SZEDER Gábor writes: Arguably this helper function could be just a simple variable. I opted for a function because: - I preferred a single '#ifdef NO_POSIX_GOODIES', and putting a static variable so near to EOF felt just wrong. (And this is why it's not

Re: [RFC PATCH] gc --auto: don't lie about running in background on Windows

2016-05-05 Thread Junio C Hamano
SZEDER Gábor writes: > Arguably this helper function could be just a simple variable. I > opted for a function because: > > - I preferred a single '#ifdef NO_POSIX_GOODIES', and putting a > static variable so near to EOF felt just wrong. (And this is why > it's not an inline-able func

[RFC PATCH] gc --auto: don't lie about running in background on Windows

2016-05-05 Thread SZEDER Gábor
When 'git gc --auto' is invoked it tells the user whether it is about to auto pack the repository in the background or in the foreground depending on 'gc.autoDetach' (enabled by default). However, going to the background is not supported at all on Windows, yet 'git gc --auto' by default claims tha