Re: [RFC 04/11] coccicheck: detect hashmap_entry.hash assignment

2019-09-09 Thread Junio C Hamano
Eric Wong writes: > Eric Wong wrote: >> By renaming the "hash" field to "_hash", it's easy to spot >> improper initialization of hashmap_entry structs which >> can leave "hashmap_entry.next" uninitialized. > > Junio, I'm planning to reroll this series. > (Sorry for not following up sooner) > > W

[RFC 04/11] coccicheck: detect hashmap_entry.hash assignment

2019-09-08 Thread Eric Wong
Eric Wong wrote: > By renaming the "hash" field to "_hash", it's easy to spot > improper initialization of hashmap_entry structs which > can leave "hashmap_entry.next" uninitialized. Junio, I'm planning to reroll this series. (Sorry for not following up sooner) Would you prefer I drop 04/11 "has