Re: [RFC] Git.pm: stat the FD to ensure the file is really open

2014-10-30 Thread Eric Wong
"Kyle J. McKay" wrote: > On Oct 30, 2014, at 15:08, Eric Wong wrote: > >For a (currently) unknown reason, Git::SVN::Fetcher::close_file > >sometimes triggers "Bad file descriptor" errors on syswrite when > >writing symlink contents on the "svn_hash" tempfile. > > > >The current IO::Handle::opened

Re: [RFC] Git.pm: stat the FD to ensure the file is really open

2014-10-30 Thread Kyle J. McKay
On Oct 30, 2014, at 15:08, Eric Wong wrote: For a (currently) unknown reason, Git::SVN::Fetcher::close_file sometimes triggers "Bad file descriptor" errors on syswrite when writing symlink contents on the "svn_hash" tempfile. The current IO::Handle::opened call in Git.pm is not a sufficient chec

[RFC] Git.pm: stat the FD to ensure the file is really open

2014-10-30 Thread Eric Wong
For a (currently) unknown reason, Git::SVN::Fetcher::close_file sometimes triggers "Bad file descriptor" errors on syswrite when writing symlink contents on the "svn_hash" tempfile. The current IO::Handle::opened call in Git.pm is not a sufficient check, as the underlying file descriptor is closed