Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-13 Thread Christian Couder
On Wed, Jul 13, 2016 at 5:16 PM, Duy Nguyen wrote: > On Tue, Jul 12, 2016 at 9:45 PM, Christian Couder > wrote: >> On Tue, Jul 12, 2016 at 5:12 PM, Duy Nguyen wrote: >>> >>> No. People could create an index file anywhere in theory. So you don't >>> know how many index files there are. >> >> Mayb

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-13 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 9:45 PM, Christian Couder wrote: > On Tue, Jul 12, 2016 at 5:12 PM, Duy Nguyen wrote: >> >> No. People could create an index file anywhere in theory. So you don't >> know how many index files there are. > > Maybe when an index file is created, its path and its sharedindex

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-12 Thread Christian Couder
On Tue, Jul 12, 2016 at 5:12 PM, Duy Nguyen wrote: > > No. People could create an index file anywhere in theory. So you don't > know how many index files there are. Maybe when an index file is created, its path and its sharedindex file could be appended into a log file. We could check this log fi

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-12 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 9:04 AM, Christian Couder wrote: > On Mon, Jul 11, 2016 at 8:27 PM, Duy Nguyen wrote: >> On Mon, Jul 11, 2016 at 7:22 PM, Christian Couder >> wrote: >>> Everytime split index is turned on, it creates a "sharedindex." >>> file in the git directory. This makes sure that

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-12 Thread Christian Couder
On Mon, Jul 11, 2016 at 8:27 PM, Duy Nguyen wrote: > On Mon, Jul 11, 2016 at 7:22 PM, Christian Couder > wrote: >> Everytime split index is turned on, it creates a "sharedindex." >> file in the git directory. This makes sure that old sharedindex >> files are removed after a new one has been c

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-11 Thread Duy Nguyen
On Mon, Jul 11, 2016 at 7:22 PM, Christian Couder wrote: > Everytime split index is turned on, it creates a "sharedindex." > file in the git directory. This makes sure that old sharedindex > files are removed after a new one has been created. Hmm it's one-way link, we don't know how many inde

[RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-11 Thread Christian Couder
Everytime split index is turned on, it creates a "sharedindex." file in the git directory. This makes sure that old sharedindex files are removed after a new one has been created. Signed-off-by: Christian Couder --- read-cache.c | 27 ++- t/t1700-split-index