Re: [RFC/PATCH 5/5] completion: refactor __gitcomp_1

2012-11-17 Thread SZEDER Gábor
On Sat, Nov 17, 2012 at 12:27:40PM +0100, Felipe Contreras wrote: > On Sat, Nov 17, 2012 at 11:58 AM, SZEDER Gábor wrote: > > >> # The following function is based on code from: > >> @@ -249,10 +246,16 @@ __gitcomp () > >> --*=) > >> ;; > >> *) > >> - local I

Re: [RFC/PATCH 5/5] completion: refactor __gitcomp_1

2012-11-17 Thread Felipe Contreras
On Sat, Nov 17, 2012 at 11:58 AM, SZEDER Gábor wrote: >> # The following function is based on code from: >> @@ -249,10 +246,16 @@ __gitcomp () >> --*=) >> ;; >> *) >> - local IFS=$'\n' >> - __gitcompadd "$(__gitcomp_1 "${1-}" "${4-}")" "${2-}" "$

Re: [RFC/PATCH 5/5] completion: refactor __gitcomp_1

2012-11-17 Thread SZEDER Gábor
[Wow, that's quite the Cc-list above. I wonder why e.g. Robert ended up there, when all his "sins" were to add a couple of 'git svn' options back in 2009.] On Sat, Nov 17, 2012 at 02:38:18AM +0100, Felipe Contreras wrote: > It's only used by __gitcomp, so move some code there and avoid going > th

[RFC/PATCH 5/5] completion: refactor __gitcomp_1

2012-11-16 Thread Felipe Contreras
It's only used by __gitcomp, so move some code there and avoid going through the loop again. We could get rid of it altogether, but it's useful for zsh's completion wrapper. Signed-off-by: Felipe Contreras --- contrib/completion/git-completion.bash | 25 ++--- 1 file changed