Re: [RFC/PATCH 4/4] replace: add --edit option

2014-03-07 Thread Jeff King
On Thu, Mar 06, 2014 at 08:57:58PM -0500, Eric Sunshine wrote: > > + if (strbuf_read(&result, cmd.out, 41) < 0) > > + die_errno("unable to read from mktree"); > > + close(cmd.out); > > + > > + if (finish_command(&cmd)) > > +

Re: [RFC/PATCH 4/4] replace: add --edit option

2014-03-06 Thread Eric Sunshine
On Thu, Mar 6, 2014 at 12:51 PM, Jeff King wrote: > This allows you to run: > > git replace --edit SHA1 > > to get dumped in an editor with the contents of the object > for SHA1. The result is then read back in and used as a > "replace" object for SHA1. The writing/reading is > type-aware, so

[RFC/PATCH 4/4] replace: add --edit option

2014-03-06 Thread Jeff King
This allows you to run: git replace --edit SHA1 to get dumped in an editor with the contents of the object for SHA1. The result is then read back in and used as a "replace" object for SHA1. The writing/reading is type-aware, so you get to edit "ls-tree" output rather than the binary tree form