CI builds on GitGitGadget, was Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-06 Thread Johannes Schindelin
Hi Junio, On Thu, 6 Jun 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> I vaguely recall seeing just one 'x' once. I think last time I had a > >> problem with truncating st_ino, but that should be fixed in e66ceca94b > >> (clone: fix colliding file detection on APFS, 2018-11-20)

Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-06 Thread Junio C Hamano
Johannes Schindelin writes: >> I vaguely recall seeing just one 'x' once. I think last time I had a >> problem with truncating st_ino, but that should be fixed in e66ceca94b >> (clone: fix colliding file detection on APFS, 2018-11-20). So no idea >> how this happens again. > > Good catch. I think

Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-06 Thread Johannes Schindelin
Hi Duy, On Wed, 5 Jun 2019, Duy Nguyen wrote: > On Wed, Jun 5, 2019 at 6:27 PM Jeff King wrote: > > > > On Wed, Jun 05, 2019 at 10:12:12AM +0200, Johannes Schindelin wrote: > > > > > This fails on macOS, in t5601, both in our osx-clang and osx-gcc jobs, as > > > well as in the StaticAnalysis job

Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-05 Thread Duy Nguyen
On Wed, Jun 5, 2019 at 6:27 PM Jeff King wrote: > > On Wed, Jun 05, 2019 at 10:12:12AM +0200, Johannes Schindelin wrote: > > > This fails on macOS, in t5601, both in our osx-clang and osx-gcc jobs, as > > well as in the StaticAnalysis job. For details, see > > https://dev.azure.com/gitgitgadget/gi

Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-05 Thread Jeff King
On Wed, Jun 05, 2019 at 10:12:12AM +0200, Johannes Schindelin wrote: > This fails on macOS, in t5601, both in our osx-clang and osx-gcc jobs, as > well as in the StaticAnalysis job. For details, see > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=10206 Hmm. I'm having a hard time

Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-05 Thread Johannes Schindelin
On Mon, 3 Jun 2019, Felipe Contreras wrote: > Felipe Contreras (5): > t5801 (remote-helpers): cleanup refspec stuff > t5801 (remote-helpers): add test to fetch tags > fetch: trivial cleanup > fetch: make the code more understandable > fetch: fix regression with transport helpers > > bui

Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-04 Thread Felipe Contreras
On Tue, Jun 4, 2019 at 9:35 AM Jeff King wrote: > > On Mon, Jun 03, 2019 at 09:13:25PM -0500, Felipe Contreras wrote: > > I'm not exactly sure the solution is the one we want, but hopefull it gives > > an > > idea as to what is needed. > > It looks good to me. Thanks for fixing this. > > The bre

Re: [RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-04 Thread Jeff King
On Mon, Jun 03, 2019 at 09:13:25PM -0500, Felipe Contreras wrote: > I noticed a regression with running tests for git-remote-hg; can't seem to be > able to fetch tags. > > Probably all remote helpers that use the import method are affected, if not > all. > > The following patches are meant to te

[RFC/PATCH 0/5] Fix fetch regression with transport helpers

2019-06-03 Thread Felipe Contreras
I noticed a regression with running tests for git-remote-hg; can't seem to be able to fetch tags. Probably all remote helpers that use the import method are affected, if not all. The following patches are meant to test for the issue, fix it, and get some cleanups. I'm not exactly sure the soluti