Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-21 Thread Kazutoshi Satoda
On 2016/02/21 8:37 +0900, Eric Wong wrote: > Kazutoshi Satoda wrote: ... >> Setting LC_ALL=C.UTF-8 in the test 11-12 made them pass on Cygwin. >> Same change made the previous version also pass. Please find the patch >> in the attached output of git format-patch. > > Thanks. However, I also wond

Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-20 Thread Eric Wong
Kazutoshi Satoda wrote: > (Shouldn't the branch be based on maint, as these are bugfixes?) I'm not sure if it being previously left-out/untested feature would qualify for maint. Maybe it does, but I suppose I'll let Junio decide. > Thank you. I tried it but got similar problem: > I found how

Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-16 Thread Kazutoshi Satoda
On 2016/02/16 15:33 +0900, Eric Wong wrote: > Kazutoshi Satoda wrote: >> Thank you for the tests. But, on my environment, both of them failed >> unexpectedly. (Windows 7 SP1, x86_64 Cygwin, LANG=ja_JP.UTF-8) ... >> > Untracked files: >> > svnrepo/ >> > "\357\202\201\357\202\202" >>

Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-15 Thread Eric Wong
Junio, sorry about basing on next, I somehow thought I was going to need to depend on something there. Updated pull below if Kazutoshi can run the test effectively. Kazutoshi Satoda wrote: > Thank you for the tests. But, on my environment, both of them failed > unexpectedly. (Windows 7 SP1, x86_6

Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-15 Thread Kazutoshi Satoda
On 2016/02/15 9:52 +0900, Eric Wong wrote: > I've amended tests to both commits, but the URL encoding one > requires an HTTP server to test effectively. Thank you for the tests. But, on my environment, both of them failed unexpectedly. (Windows 7 SP1, x86_64 Cygwin, LANG=ja_JP.UTF-8) For now, I d

Re: [PULL] svn pathnameencoding for git svn dcommit

2016-02-15 Thread Junio C Hamano
Eric Wong writes: > I've amended tests to both commits, but the URL encoding one > requires an HTTP server to test effectively. > > I couldn't find a test prereq for httpd, but perhaps it's good > to test by default regardless in case a future SVN changes > file:// behavior. I've only tested thi

[PULL] svn pathnameencoding for git svn dcommit

2016-02-14 Thread Eric Wong
I've amended tests to both commits, but the URL encoding one requires an HTTP server to test effectively. I couldn't find a test prereq for httpd, but perhaps it's good to test by default regardless in case a future SVN changes file:// behavior. I've only tested this with SVN 1.6.17 under Debian