On Tue, Dec 30, 2014 at 3:33 PM, Stefan Beller wrote:
> On Mon, Dec 29, 2014 at 10:11 PM, Eric Sunshine
> wrote:
>> On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote:
>>> +static int should_process_cmd(struct command *cmd)
>>> +{
>>> + if (cmd->error_string)
>>> + return
On Mon, Dec 29, 2014 at 10:11 PM, Eric Sunshine wrote:
> On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote:
>> No functional changes intended.
>
> This is useful to know but is of secondary importance, thus should be
> placed after the explanation and justification of the change.
>
>> Subject:
On Tue, Dec 30, 2014 at 3:42 AM, Stefan Beller wrote:
> On Mon, Dec 29, 2014 at 11:46 PM, Eric Sunshine
> wrote:
>> On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote:
>>> No functional changes intended.
>>> +static void check_shallow_bugs(struct command *commands,
>>> +
On Mon, Dec 29, 2014 at 11:46 PM, Eric Sunshine wrote:
> On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote:
>> No functional changes intended.
>>
>> This commit shortens execute_commands by moving some parts of the code
>> to extra functions.
>>
>> Suggested-by: Eric Sunshine
>> Signed-off-by
reply to all instead of reply to Eric only.
On Mon, Dec 29, 2014 at 10:11 PM, Eric Sunshine wrote:
> In v6, you considered this a fatal error in the atomic case, which
> caused the entire transaction to be rolled back. However, in this
> version, this error has no effect whatsoever on the atomic
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote:
> No functional changes intended.
>
> This commit shortens execute_commands by moving some parts of the code
> to extra functions.
>
> Suggested-by: Eric Sunshine
> Signed-off-by: Stefan Beller
> ---
> diff --git a/builtin/receive-pack.c b/bu
On Mon, Dec 29, 2014 at 9:36 PM, Stefan Beller wrote:
> No functional changes intended.
This is useful to know but is of secondary importance, thus should be
placed after the explanation and justification of the change.
> Subject: receive-pack.c: simplify execute_commands
> This commit shortens
No functional changes intended.
This commit shortens execute_commands by moving some parts of the code
to extra functions.
Suggested-by: Eric Sunshine
Signed-off-by: Stefan Beller
---
Notes:
v8: no change
v7:
new in v7 as in v7 I'd split up the previous
[PATCH 4/7] recei
8 matches
Mail list logo
