Re: [PATCHv6 4/7] worktree: get worktrees from submodules

2016-12-09 Thread Stefan Beller
On Fri, Dec 9, 2016 at 3:00 PM, Brandon Williams wrote: > On 12/08, Stefan Beller wrote: >> On Thu, Dec 8, 2016 at 2:09 AM, Duy Nguyen wrote: >> > On Thu, Dec 8, 2016 at 8:46 AM, Stefan Beller wrote: >> >> >> >> worktree = xcalloc(1, sizeof(*worktree)); >> >> worktree->path = str

Re: [PATCHv6 4/7] worktree: get worktrees from submodules

2016-12-09 Thread Brandon Williams
On 12/08, Stefan Beller wrote: > On Thu, Dec 8, 2016 at 2:09 AM, Duy Nguyen wrote: > > On Thu, Dec 8, 2016 at 8:46 AM, Stefan Beller wrote: > >> > >> worktree = xcalloc(1, sizeof(*worktree)); > >> worktree->path = strbuf_detach(&worktree_path, NULL); > >> @@ -101,7 +101,8 @@ stati

Re: [PATCHv6 4/7] worktree: get worktrees from submodules

2016-12-09 Thread Duy Nguyen
On Fri, Dec 9, 2016 at 1:55 AM, Stefan Beller wrote: > On Thu, Dec 8, 2016 at 2:09 AM, Duy Nguyen wrote: >> On Thu, Dec 8, 2016 at 8:46 AM, Stefan Beller wrote: >>> >>> worktree = xcalloc(1, sizeof(*worktree)); >>> worktree->path = strbuf_detach(&worktree_path, NULL); >>> @@ -101

Re: [PATCHv6 4/7] worktree: get worktrees from submodules

2016-12-08 Thread Stefan Beller
On Thu, Dec 8, 2016 at 2:09 AM, Duy Nguyen wrote: > On Thu, Dec 8, 2016 at 8:46 AM, Stefan Beller wrote: >> >> worktree = xcalloc(1, sizeof(*worktree)); >> worktree->path = strbuf_detach(&worktree_path, NULL); >> @@ -101,7 +101,8 @@ static struct worktree *get_main_worktree(void)

Re: [PATCHv6 4/7] worktree: get worktrees from submodules

2016-12-08 Thread Duy Nguyen
On Thu, Dec 8, 2016 at 8:46 AM, Stefan Beller wrote: > > worktree = xcalloc(1, sizeof(*worktree)); > worktree->path = strbuf_detach(&worktree_path, NULL); > @@ -101,7 +101,8 @@ static struct worktree *get_main_worktree(void) All the good stuff is outside context lines again.. Some

[PATCHv6 4/7] worktree: get worktrees from submodules

2016-12-07 Thread Stefan Beller
In a later patch we want to move around the the git directory of a submodule. Both submodules as well as worktrees are involved in placing git directories at unusual places, so their functionality may collide. To react appropriately to situations where worktrees in submodules are in use, offer a ne