Re: [PATCHv6 1/2] submodule tests: don't use itself as a submodule

2017-01-09 Thread Stefan Beller
On Sun, Jan 8, 2017 at 6:33 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> This provides an easier way to have submodules in tests, by just setting >> TEST_CREATE_SUBMODULE to a non empty string, similar to >> TEST_NO_CREATE_REPO. > > Yuck. > > I find it doubtful that it is a good idea to

Re: [PATCHv6 1/2] submodule tests: don't use itself as a submodule

2017-01-08 Thread Junio C Hamano
Stefan Beller writes: > This provides an easier way to have submodules in tests, by just setting > TEST_CREATE_SUBMODULE to a non empty string, similar to > TEST_NO_CREATE_REPO. Yuck. I find it doubtful that it is a good idea to create two submodule repositories by merely dot-including the te

[PATCHv6 1/2] submodule tests: don't use itself as a submodule

2017-01-05 Thread Stefan Beller
In reality nobody would run "git submodule add ./. " to add the repository to itself as a submodule as this comes with some nasty surprises, such as infinite recursion when cloning that repository. However we do this all the time in the test suite, because most of the time this was the most conveni