On Tue, Jun 13, 2017 at 3:07 PM, Jonathan Tan wrote:
>> +struct diff_line {
>
> Probably should be called diff_emission (or just emission), since these
> may not be full lines.
I think emitted_string would do as well?
>
> Also, can this definition be in the .c file? Callers should use the
> dif
On Wed, 24 May 2017 14:40:35 -0700
Stefan Beller wrote:
> diff --git a/diff.h b/diff.h
> index 85948ed65a..fad1258556 100644
> --- a/diff.h
> +++ b/diff.h
> @@ -115,6 +115,42 @@ enum diff_submodule_format {
> DIFF_SUBMODULE_INLINE_DIFF
> };
>
> +/*
> + * This struct is used when we need
Stefan Beller writes:
> Yes, this is essentially the v4 with small indentation fixes, so I
> assumed your signoff is still valid.
OK. I just didn't expect to see one without "no changes since v4"
under the three-dash line.
Thanks.
On Wed, May 24, 2017 at 7:26 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> Introduce a new option 'use_buffer' in the struct diff_options which
>> controls whether all output is buffered up until all output is available.
>> ...
>> Unconditionally enable output via buffer in this patch as
Stefan Beller writes:
> Introduce a new option 'use_buffer' in the struct diff_options which
> controls whether all output is buffered up until all output is available.
> ...
> Unconditionally enable output via buffer in this patch as it yields
> a great opportunity for testing, i.e. all the diff
Introduce a new option 'use_buffer' in the struct diff_options which
controls whether all output is buffered up until all output is available.
We'll have a new struct 'diff_line' in diff.h which will be used to buffer
each line. The diff_line will duplicate the memory of the line to buffer
as tha
6 matches
Mail list logo
