Re: [PATCHv5 0/4] Push options

2016-07-14 Thread Jeff King
On Thu, Jul 14, 2016 at 11:48:58AM -0700, Stefan Beller wrote: > > Hmm. So that is a downside for people who have implemented separate > > DoS protection only in that upgrading git will open a new "hole" > > that they need to plug. But that is their problem, not upstream > > git's. > > > > -Peff >

Re: [PATCHv5 0/4] Push options

2016-07-14 Thread Stefan Beller
On Thu, Jul 14, 2016 at 11:41 AM, Jeff King wrote: > On Thu, Jul 14, 2016 at 10:39:16AM -0700, Stefan Beller wrote: > >> Jeff wrote: >> > Junio wrote: >> >> I think those extra knobs can come later. If we are not going to >> >> limit with max_options in the end, however, wouldn't it be more >> >>

Re: [PATCHv5 0/4] Push options

2016-07-14 Thread Jeff King
On Thu, Jul 14, 2016 at 10:39:16AM -0700, Stefan Beller wrote: > Jeff wrote: > > Junio wrote: > >> I think those extra knobs can come later. If we are not going to > >> limit with max_options in the end, however, wouldn't it be more > >> natural for the initial iteration without any configuration

[PATCHv5 0/4] Push options

2016-07-14 Thread Stefan Beller
Jeff wrote: > Junio wrote: >> I think those extra knobs can come later. If we are not going to >> limit with max_options in the end, however, wouldn't it be more >> natural for the initial iteration without any configuration not to >> have hard-coded max_options at all? > > Yeah, I am OK with addi