Re: [PATCHv5] submodule deinit: require '--all' instead of '.' for all submodules

2016-05-05 Thread Junio C Hamano
On Thu, May 5, 2016 at 1:37 PM, Jonathan Nieder wrote: > Stefan Beller wrote: > >>>$ rungit v2.6.6 submodule deinit . >>>error: pathspec '.' did not match any file(s) known to git. >>>Did you forget to 'git add'? > [...] >> So instead of a pathspec add the '--all' option to

Re: [PATCHv5] submodule deinit: require '--all' instead of '.' for all submodules

2016-05-05 Thread Jonathan Nieder
Stefan Beller wrote: >>$ rungit v2.6.6 submodule deinit . >>error: pathspec '.' did not match any file(s) known to git. >>Did you forget to 'git add'? [...] > So instead of a pathspec add the '--all' option to deinit all submodules > and add a test to check for the corner c

[PATCHv5] submodule deinit: require '--all' instead of '.' for all submodules

2016-05-05 Thread Stefan Beller
The discussion in [1] pointed out that '.' is a faulty suggestion as there is a corner case where it fails: > "submodule deinit ." may have "worked" in the sense that you would > have at least one path in your tree and avoided this "nothing > matches" most of the time. It would have still failed