Re: [PATCHv4 7/7] builtin/describe.c: describe a blob

2017-11-16 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> grep "fatal: test-blob-1 is neither a commit nor blob" actual > > OK, that might be somewhat unsatisfying from end-user's point of > view (logically "test-blob-1" is already a name based on the 'graph > relations' that is satisfactory). ..

Re: [PATCHv4 7/7] builtin/describe.c: describe a blob

2017-11-15 Thread Junio C Hamano
Stefan Beller writes: > grep "fatal: test-blob-1 is neither a commit nor blob" actual OK, that might be somewhat unsatisfying from end-user's point of view (logically "test-blob-1" is already a name based on the 'graph relations' that is satisfactory). [side note] should that grep b

Re: [PATCHv4 7/7] builtin/describe.c: describe a blob

2017-11-15 Thread Stefan Beller
> > Give an object a human readable name based on an available ref > > or something like that? will use > Or a sentence in BUGS section. will add. > A case (or two) I find more interesting is to see how the code > behaves against these: > > git tag -a -m "annotated blob" a-blob HEAD

Re: [PATCHv4 7/7] builtin/describe.c: describe a blob

2017-11-15 Thread Junio C Hamano
Stefan Beller writes: >>> -git-describe - Describe a commit using the most recent tag reachable from >>> it >>> +git-describe - Describe a commit or blob using the graph relations >> >> I would write "Describe a commit or blob using a tag reachable from it". > > using a ref, as we also can use r

Re: [PATCHv4 7/7] builtin/describe.c: describe a blob

2017-11-15 Thread Stefan Beller
On Tue, Nov 14, 2017 at 5:52 PM, Jonathan Tan wrote: > On Tue, 14 Nov 2017 16:30:43 -0800 > Stefan Beller wrote: > >> The walking is performed in reverse order to show the introduction of a >> blob rather than its last occurrence. > > The code as implemented here does not do this - it instead sho

Re: [PATCHv4 7/7] builtin/describe.c: describe a blob

2017-11-14 Thread Jonathan Tan
On Tue, 14 Nov 2017 16:30:43 -0800 Stefan Beller wrote: > The walking is performed in reverse order to show the introduction of a > blob rather than its last occurrence. The code as implemented here does not do this - it instead shows the last occurrence. > NAME > > -git-describe - Descr

[PATCHv4 7/7] builtin/describe.c: describe a blob

2017-11-14 Thread Stefan Beller
Sometimes users are given a hash of an object and they want to identify it further (ex.: Use verify-pack to find the largest blobs, but what are these? or [1]) When describing commits, we try to anchor them to tags or refs, as these are conceptually on a higher level than the commit. And if there