Re: [PATCHv4 3/6] Git.pm: refactor command_close_bidi_pipe to use _cmd_close

2013-02-12 Thread Junio C Hamano
Michal Nazarewicz writes: >>> Michal Nazarewicz writes: >>> > The body of the loop in command_close_bidi_pipe function is identical to >>> > what _cmd_close function does so instead of duplicating, refactor change >>> > _cmd_close so that it accepts list of file handlers to be closed, which > >>

Re: [PATCHv4 3/6] Git.pm: refactor command_close_bidi_pipe to use _cmd_close

2013-02-12 Thread Michal Nazarewicz
>> Michal Nazarewicz writes: >> > The body of the loop in command_close_bidi_pipe function is identical to >> > what _cmd_close function does so instead of duplicating, refactor change >> > _cmd_close so that it accepts list of file handlers to be closed, which > On Tue, Feb 12, 2013 at 10:55:05A

Re: [PATCHv4 3/6] Git.pm: refactor command_close_bidi_pipe to use _cmd_close

2013-02-12 Thread Jeff King
On Tue, Feb 12, 2013 at 10:55:05AM -0800, Junio C Hamano wrote: > Michal Nazarewicz writes: > > > From: Michal Nazarewicz > > > > The body of the loop in command_close_bidi_pipe function is identical to > > what _cmd_close function does so instead of duplicating, refactor change > > _cmd_close

Re: [PATCHv4 3/6] Git.pm: refactor command_close_bidi_pipe to use _cmd_close

2013-02-12 Thread Junio C Hamano
Michal Nazarewicz writes: > From: Michal Nazarewicz > > The body of the loop in command_close_bidi_pipe function is identical to > what _cmd_close function does so instead of duplicating, refactor change > _cmd_close so that it accepts list of file handlers to be closed, which s/file handlers/f

[PATCHv4 3/6] Git.pm: refactor command_close_bidi_pipe to use _cmd_close

2013-02-12 Thread Michal Nazarewicz
From: Michal Nazarewicz The body of the loop in command_close_bidi_pipe function is identical to what _cmd_close function does so instead of duplicating, refactor change _cmd_close so that it accepts list of file handlers to be closed, which makes it usable with command_close_bidi_pipe. Signed-o