Re: [PATCHv4 3/3] submodule: implement `clone` as a builtin helper

2015-09-01 Thread Eric Sunshine
On Tue, Sep 1, 2015 at 3:05 PM, Jeff King wrote: > On Tue, Sep 01, 2015 at 02:52:54PM -0400, Eric Sunshine wrote: >> > + /* Redirect the worktree of the submodule in the superproject's >> > config */ >> > + if (strbuf_getcwd(&sb)) >> > + die_errno(_("unable to get curren

Re: [PATCHv4 3/3] submodule: implement `clone` as a builtin helper

2015-09-01 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, Sep 1, 2015 at 2:24 PM, Stefan Beller wrote: >> This converts implements the helper `module_clone`. This functionality is > > Mentioned previously[1]: "converts implements"? > > [1]: http://article.gmane.org/gmane.comp.version-control.git/276966 Stefan, perhaps a

Re: [PATCHv4 3/3] submodule: implement `clone` as a builtin helper

2015-09-01 Thread Jeff King
On Tue, Sep 01, 2015 at 02:52:54PM -0400, Eric Sunshine wrote: > > + /* Redirect the worktree of the submodule in the superproject's > > config */ > > + if (strbuf_getcwd(&sb)) > > + die_errno(_("unable to get current working directory")); > > + > > + if (!is_absol

Re: [PATCHv4 3/3] submodule: implement `clone` as a builtin helper

2015-09-01 Thread Eric Sunshine
On Tue, Sep 1, 2015 at 2:24 PM, Stefan Beller wrote: > This converts implements the helper `module_clone`. This functionality is Mentioned previously[1]: "converts implements"? [1]: http://article.gmane.org/gmane.comp.version-control.git/276966 > needed for converting `git submodule update` lat

[PATCHv4 3/3] submodule: implement `clone` as a builtin helper

2015-09-01 Thread Stefan Beller
This converts implements the helper `module_clone`. This functionality is needed for converting `git submodule update` later on, which we want to add threading to. Signed-off-by: Stefan Beller --- builtin/submodule--helper.c | 140 git-submodule.sh