Re: [PATCHv4 12/14] git submodule update: cmd_update_clone

2015-09-23 Thread Junio C Hamano
Stefan Beller writes: > Split the cloning part out to its own function, > this allow us in a later patch to convert cmd_update in C. > > Signed-off-by: Stefan Beller > --- It appears that this is not just a refactor and loses the logic around $cloned_modules variable that seems to avoid doing t

[PATCHv4 12/14] git submodule update: cmd_update_clone

2015-09-22 Thread Stefan Beller
Split the cloning part out to its own function, this allow us in a later patch to convert cmd_update in C. Signed-off-by: Stefan Beller --- git-submodule.sh | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh i