Re: [PATCHv4 1/3] submodule: implement `list` as a builtin helper

2015-09-02 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> +static int module_list_compute(int argc, const char **argv, >> +const char *prefix, >> +struct pathspec *pathspec) >> +{ >> ... >> +for (i = 0; i < active_nr; i++) { >> +c

Re: [PATCHv4 1/3] submodule: implement `list` as a builtin helper

2015-09-01 Thread Eric Sunshine
On Tue, Sep 1, 2015 at 2:24 PM, Stefan Beller wrote: > Most of the submodule operations work on a set of submodules. > Calculating and using this set is usually done via: > >module_list "$@" | { >while read mode sha1 stage sm_path >do > # the actual

Re: [PATCHv4 1/3] submodule: implement `list` as a builtin helper

2015-09-01 Thread Stefan Beller
please ignore. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCHv4 1/3] submodule: implement `list` as a builtin helper

2015-09-01 Thread Stefan Beller
Most of the submodule operations work on a set of submodules. Calculating and using this set is usually done via: module_list "$@" | { while read mode sha1 stage sm_path do # the actual operation done } Currently the function `module_

Re: [PATCHv4 1/3] submodule: implement `list` as a builtin helper

2015-09-01 Thread Junio C Hamano
Stefan Beller writes: > +static int module_list_compute(int argc, const char **argv, > + const char *prefix, > + struct pathspec *pathspec) > +{ > + int i, result = 0; > + char *max_prefix, *ps_matched = NULL; > + int max_prefix_

[PATCHv4 1/3] submodule: implement `list` as a builtin helper

2015-09-01 Thread Stefan Beller
Most of the submodule operations work on a set of submodules. Calculating and using this set is usually done via: module_list "$@" | { while read mode sha1 stage sm_path do # the actual operation done } Currently the function `module_