Re: [PATCHv4] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Ted Zlatanov
On Tue, 05 Feb 2013 14:09:58 -0800 Junio C Hamano wrote: JCH> open $io, "-|", qw(gpg --decrypt), $ARGV[0] OK, the below will be in PATCHv6 (I'll wait on mailing it until after you've reviewed the rest of PATCHv5). Thanks for checking... I must have had a typo or a missing comma or something, I

Re: [PATCHv4] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Junio C Hamano
Ted Zlatanov writes: > On Tue, 05 Feb 2013 11:53:20 -0800 Junio C Hamano wrote: > > I think it's more readable with large loops, and it actually makes sense > when you read the code. Not a big deal to me either, I just felt for > this particular script it was OK. > >>> + if ($file =~ m/\.gpg

Re: [PATCHv4] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Ted Zlatanov
On Tue, 05 Feb 2013 11:53:20 -0800 Junio C Hamano wrote: JCH> Ted Zlatanov writes: >> Changes since PATCHv3: >> >> - simple tests in Makefile >> - support multiple files, code refactored >> - documentation and comments updated >> - fix IO::File for GPG pipe >> - exit peacefully in almost every

Re: [PATCHv4] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Junio C Hamano
Ted Zlatanov writes: > Changes since PATCHv3: > > - simple tests in Makefile > - support multiple files, code refactored > - documentation and comments updated > - fix IO::File for GPG pipe > - exit peacefully in almost every situation, die on bad invocation or query > - use log_verbose() and -v

[PATCHv4] Add contrib/credentials/netrc with GPG support

2013-02-05 Thread Ted Zlatanov
Changes since PATCHv3: - simple tests in Makefile - support multiple files, code refactored - documentation and comments updated - fix IO::File for GPG pipe - exit peacefully in almost every situation, die on bad invocation or query - use log_verbose() and -v for logging for the user - use log_deb