Re: [PATCHv3 3/6] line-log.c: fix a memleak

2015-03-31 Thread Junio C Hamano
Stefan Beller writes: > On 30.03.2015 22:06, Junio C Hamano wrote: >> If add-line-range does not take ownership of >> parent_range from us, shouldn't we be freeing it whether we called >> it or not??? > > In my understanding it does take ownership of it. (According to my code > review on friday)

Re: [PATCHv3 3/6] line-log.c: fix a memleak

2015-03-30 Thread Stefan Beller
On 30.03.2015 22:06, Junio C Hamano wrote: > If add-line-range does not take ownership of > parent_range from us, shouldn't we be freeing it whether we called > it or not??? In my understanding it does take ownership of it. (According to my code review on friday) -- To unsubscribe from this list:

Re: [PATCHv3 3/6] line-log.c: fix a memleak

2015-03-30 Thread Junio C Hamano
Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > line-log.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/line-log.c b/line-log.c > index b43ac58..db6e58d 100644 > --- a/line-log.c > +++ b/line-log.c > @@ -1129,6 +1129,9 @@ static int process_ranges_ordinary_commit(str

Re: [PATCHv3 3/6] line-log.c: fix a memleak

2015-03-30 Thread Torsten Bögershausen
On 03/31/2015 03:22 AM, Stefan Beller wrote: Signed-off-by: Stefan Beller --- line-log.c | 3 +++ 1 file changed, 3 insertions(+) Would it make sense to join 2/6 and 3/6 into a single patch ? Both fix the memleaks in the same file, and the header can be "fix memleaks". -- To unsubscribe f

[PATCHv3 3/6] line-log.c: fix a memleak

2015-03-30 Thread Stefan Beller
Signed-off-by: Stefan Beller --- line-log.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/line-log.c b/line-log.c index b43ac58..db6e58d 100644 --- a/line-log.c +++ b/line-log.c @@ -1129,6 +1129,9 @@ static int process_ranges_ordinary_commit(struct rev_info *rev, struct commit *c