Re: [PATCHv3 2/3] patch-ids.c: use hashmap correctly

2017-07-05 Thread Jeff King
On Fri, Jun 30, 2017 at 12:14:06PM -0700, Stefan Beller wrote: > As eluded to in the previous patch, the code in patch-ids.c is using > the hashmaps API wrong. > > Luckily we do not have a bug, as all hashmap functionality that we use > here (hashmap_get) passes through the keydata. If hashmap_g

Re: [PATCHv3 2/3] patch-ids.c: use hashmap correctly

2017-06-30 Thread Junio C Hamano
Stefan Beller writes: > As eluded to in the previous patch, the code in patch-ids.c is using > the hashmaps API wrong. > > Luckily we do not have a bug, as all hashmap functionality that we use > here (hashmap_get) passes through the keydata. If hashmap_get_next were > to be used, a bug would oc

[PATCHv3 2/3] patch-ids.c: use hashmap correctly

2017-06-30 Thread Stefan Beller
As eluded to in the previous patch, the code in patch-ids.c is using the hashmaps API wrong. Luckily we do not have a bug, as all hashmap functionality that we use here (hashmap_get) passes through the keydata. If hashmap_get_next were to be used, a bug would occur as that passes NULL for the key