On Tue, Aug 14, 2018 at 11:51 PM Elijah Newren wrote:
> > [...]
> > >> enums are of unknown size, so forward declarations don't work for
> > >> them. See bb/pedantic for some examples.
> > >
> > > structs are also of unknown size; the size is irrelevant when the
> > > function signature merely us
On Tue, Aug 14, 2018 at 11:13 PM Jonathan Nieder wrote:
>
> Elijah Newren wrote:
>
> > I didn't want to repeat that description in all 6 patches, since all
> > six came from that, so I put it in the cover letter. Since patch #1
> > has most that changes though, I guess it makes sense to include i
Elijah Newren wrote:
> I didn't want to repeat that description in all 6 patches, since all
> six came from that, so I put it in the cover letter. Since patch #1
> has most that changes though, I guess it makes sense to include it at
> least in that one?
Yes, that sounds sensible to me.
[...]
>
On Tue, Aug 14, 2018 at 10:10 PM Jonathan Nieder wrote:
>
> Elijah Newren wrote:
>
> > Subject: Add missing includes and forward declares
>
> nit: s/declares/declarations/
Thanks.
> This is a huge patch. Was it autogenerated or generated manually?
> Can the commit message say something about me
Elijah Newren wrote:
> Subject: Add missing includes and forward declares
nit: s/declares/declarations/
This is a huge patch. Was it autogenerated or generated manually?
Can the commit message say something about methodology?
Is there an easy way to review it? (Keep in mind that I'm super laz
Signed-off-by: Elijah Newren
---
alloc.h | 2 ++
apply.h | 3 +++
archive.h | 3 +++
attr.h| 1 +
branch.h | 2 ++
bulk-checkin.h| 2 ++
column.h | 1 +
commit-graph.h| 1 +
config.h
6 matches
Mail list logo
