Re: [PATCHv2 3/8] submodule config: remove name_and_item_from_var

2015-10-30 Thread Stefan Beller
On Thu, Oct 29, 2015 at 6:23 PM, Eric Sunshine wrote: > On Wed, Oct 28, 2015 at 7:21 PM, Stefan Beller wrote: >> submodule config: remove name_and_item_from_var >> >> By inlining `name_and_item_from_var` it is easy to add later options >> which are not required to have a submodule name. > > I gue

Re: [PATCHv2 3/8] submodule config: remove name_and_item_from_var

2015-10-29 Thread Eric Sunshine
On Wed, Oct 28, 2015 at 7:21 PM, Stefan Beller wrote: > submodule config: remove name_and_item_from_var > > By inlining `name_and_item_from_var` it is easy to add later options > which are not required to have a submodule name. I guess you're trying to say that name_and_item_from_var() didn't pro

[PATCHv2 3/8] submodule config: remove name_and_item_from_var

2015-10-28 Thread Stefan Beller
By inlining `name_and_item_from_var` it is easy to add later options which are not required to have a submodule name. Signed-off-by: Stefan Beller --- submodule-config.c | 46 +- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/submodule