Re: [PATCHv2 3/6] t7810-grep: test multiple --author with --all-match

2012-09-14 Thread Junio C Hamano
Michael J Gruber writes: > Junio C Hamano venit, vidit, dixit 14.09.2012 01:26: > ... >> when "--all-match" was given from the command line, so that the >> "committer", "author" and elements on the top-level backbone in >> "pattern" form the top-level backbone of the resulting expression to >> be

Re: [PATCHv2 3/6] t7810-grep: test multiple --author with --all-match

2012-09-14 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 14.09.2012 01:26: > Junio C Hamano writes: > >> One possible improvement we can make is to parse the command line in >> the last example with "--all-match" to >> >> [all-match] >> (or >> pattern_bodycommit >> (or >> pattern_bodytag >>

Re: [PATCHv2 3/6] t7810-grep: test multiple --author with --all-match

2012-09-13 Thread Junio C Hamano
Junio C Hamano writes: > One possible improvement we can make is to parse the command line in > the last example with "--all-match" to > > [all-match] > (or > pattern_bodycommit > (or > pattern_bodytag > (or >pattern_headLinus >(or > pattern_h

Re: [PATCHv2 3/6] t7810-grep: test multiple --author with --all-match

2012-09-13 Thread Junio C Hamano
Michael J Gruber writes: > --all-match is ignored for author matching on purpose. > > Signed-off-by: Michael J Gruber > --- What the added test expects is correct, but I do not think the above description is correct. "all-match" is implicitly turned on when you use header match. When you say

[PATCHv2 3/6] t7810-grep: test multiple --author with --all-match

2012-09-13 Thread Michael J Gruber
--all-match is ignored for author matching on purpose. Signed-off-by: Michael J Gruber --- t/t7810-grep.sh | 8 1 file changed, 8 insertions(+) diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh index 1db3dcb..9bc63a3 100755 --- a/t/t7810-grep.sh +++ b/t/t7810-grep.sh @@ -580,6 +580,14 @@