On Mon, Nov 21, 2016 at 7:37 PM, Junio C Hamano wrote:
> Doesn't (the) "above", aka submodule_from_path() want the same
> treatment?
fixed in a resend.
> I do not think the commit-sha1 (or commit-or-tree-object-name) is
> "ITS" object name for the submodule. The name belongs to the
> containin
Stefan Beller writes:
> It is also possible to pass in a tree hash to lookup a submodule config.
> Make it clear by naming the variables accrodingly. Looking up a submodule
> config by tree hash will come in handy in a later patch.
>
> Signed-off-by: Stefan Beller
> ---
Yeah, I noticed that whi
On Mon, Nov 21, 2016 at 4:16 PM, Brandon Williams wrote:
> On 11/21, Stefan Beller wrote:
>> On Mon, Nov 21, 2016 at 4:11 PM, Brandon Williams wrote:
>> > On 11/21, Stefan Beller wrote:
>> >>
>> >> switch (lookup_type) {
>> >> @@ -448,7 +448,8 @@ static const struct submodule *config_from(s
On 11/21, Stefan Beller wrote:
> On Mon, Nov 21, 2016 at 4:11 PM, Brandon Williams wrote:
> > On 11/21, Stefan Beller wrote:
> >>
> >> switch (lookup_type) {
> >> @@ -448,7 +448,8 @@ static const struct submodule *config_from(struct
> >> submodule_cache *cache,
> >>
> >> /* fill the s
On Mon, Nov 21, 2016 at 4:11 PM, Brandon Williams wrote:
> On 11/21, Stefan Beller wrote:
>>
>> switch (lookup_type) {
>> @@ -448,7 +448,8 @@ static const struct submodule *config_from(struct
>> submodule_cache *cache,
>>
>> /* fill the submodule config into the cache */
>> para
On 11/21, Stefan Beller wrote:
>
> switch (lookup_type) {
> @@ -448,7 +448,8 @@ static const struct submodule *config_from(struct
> submodule_cache *cache,
>
> /* fill the submodule config into the cache */
> parameter.cache = cache;
> - parameter.commit_sha1 = commit_sha
It is also possible to pass in a tree hash to lookup a submodule config.
Make it clear by naming the variables accrodingly. Looking up a submodule
config by tree hash will come in handy in a later patch.
Signed-off-by: Stefan Beller
---
Documentation/technical/api-submodule-config.txt | 8 ++--
7 matches
Mail list logo
