Re: [PATCHv2 0/7] Moved code detection: ignore space on uniform indentation

2018-04-24 Thread Stefan Beller
On Tue, Apr 24, 2018 at 3:37 PM, Jonathan Tan wrote: > On Tue, 24 Apr 2018 14:03:23 -0700 > Stefan Beller wrote: > >> v2: >> I think I have addressed Jonathans feedback >> * by using a string instead of counting the first character only. >> * refined tests slightly (easier to read) >> * moved whi

Re: [PATCHv2 0/7] Moved code detection: ignore space on uniform indentation

2018-04-24 Thread Jonathan Tan
On Tue, 24 Apr 2018 14:03:23 -0700 Stefan Beller wrote: > v2: > I think I have addressed Jonathans feedback > * by using a string instead of counting the first character only. > * refined tests slightly (easier to read) > * moved white space handling for moved blocks into its own flag field, >

[PATCHv2 0/7] Moved code detection: ignore space on uniform indentation

2018-04-24 Thread Stefan Beller
v2: I think I have addressed Jonathans feedback * by using a string instead of counting the first character only. * refined tests slightly (easier to read) * moved white space handling for moved blocks into its own flag field, keeping the enum for the actual mode of move detection. v1: This is a