On Mon, Nov 23, 2015 at 10:44 AM, Stefan Beller wrote:
> On Fri, Nov 20, 2015 at 10:58 PM, Torsten Bögershausen wrote:
>> On 2015-11-20 22.08, Stefan Beller wrote:
>> The patch looks good at first glance, one minor remark below:
>>>
>>> diff --git a/run-command.c b/run-command.c
>>
>>> @@ -1071,7
On Fri, Nov 20, 2015 at 10:58 PM, Torsten Bögershausen wrote:
> On 2015-11-20 22.08, Stefan Beller wrote:
> The patch looks good at first glance, one minor remark below:
>>
>> diff --git a/run-command.c b/run-command.c
>
>> @@ -1071,70 +1089,31 @@ static void pp_output(struct parallel_processes *p
On 2015-11-20 22.08, Stefan Beller wrote:
The patch looks good at first glance, one minor remark below:
>
> diff --git a/run-command.c b/run-command.c
> @@ -1071,70 +1089,31 @@ static void pp_output(struct parallel_processes *pp)
>
> static int pp_collect_finished(struct parallel_processes *pp
Am 20.11.2015 um 23:05 schrieb Jonathan Nieder:
Stefan Beller wrote:
Detect if a child stopped working by checking if their stderr pipe
was closed instead of checking their state with waitpid.
As waitpid is not fully working in Windows, this is an approach which
allows for better cross platform
Stefan Beller wrote:
> Detect if a child stopped working by checking if their stderr pipe
> was closed instead of checking their state with waitpid.
> As waitpid is not fully working in Windows, this is an approach which
> allows for better cross platform operation. (It's less code, too)
Can you
Detect if a child stopped working by checking if their stderr pipe
was closed instead of checking their state with waitpid.
As waitpid is not fully working in Windows, this is an approach which
allows for better cross platform operation. (It's less code, too)
Previously we did not close the read p
6 matches
Mail list logo
