Re: [PATCHv17 01/11] submodule-config: keep update strategy around

2016-02-25 Thread Stefan Beller
On Thu, Feb 25, 2016 at 10:06 AM, Junio C Hamano wrote: > Stefan Beller writes: > >> +int parse_submodule_update_strategy(const char *value, >> + struct submodule_update_strategy *dst) >> +{ >> + free((void*)dst->command); > > free((void *)dst->command); > > "git tbdiff" i

Re: [PATCHv17 01/11] submodule-config: keep update strategy around

2016-02-25 Thread Junio C Hamano
Stefan Beller writes: > +int parse_submodule_update_strategy(const char *value, > + struct submodule_update_strategy *dst) > +{ > + free((void*)dst->command); free((void *)dst->command); "git tbdiff" is quite handy; it didn't spot any other lossage of local tweak that wa

[PATCHv17 01/11] submodule-config: keep update strategy around

2016-02-24 Thread Stefan Beller
Currently submodule..update is only handled by git-submodule.sh. C code will start to need to make use of that value as more of the functionality of git-submodule.sh moves into library code in C. Add the update field to 'struct submodule' and populate it so it can be read as sm->update or from sm-