Jonathan Nieder writes:
> Stefan Beller wrote:
>> On Wed, Feb 24, 2016 at 1:19 PM, Jonathan Nieder wrote:
>> > Stefan Beller wrote:
>
When the callers of parallel processing machine are sloppy with their
messages, make sure the output is terminated with LF after one child
process
Stefan Beller wrote:
> On Wed, Feb 24, 2016 at 1:19 PM, Jonathan Nieder wrote:
> > Stefan Beller wrote:
>>> When the callers of parallel processing machine are sloppy with their
>>> messages, make sure the output is terminated with LF after one child
>>> process is handled.
>>
>> Why not always a
On Wed, Feb 24, 2016 at 1:19 PM, Jonathan Nieder wrote:
> Stefan Beller wrote:
>
>> When the callers of parallel processing machine are sloppy with their
>> messages, make sure the output is terminated with LF after one child
>> process is handled.
>
> Why not always add \n here?
So you propose t
Stefan Beller writes:
> On Wed, Feb 24, 2016 at 12:07 PM, Junio C Hamano wrote:
>> The inconsistency may not hurt as long as (1) the producers of the
>> message will never stuff a NUL in the middle, and (2) strbuf always
>> has the guard NUL after its contents. Even though we know that the
>> l
On Wed, Feb 24, 2016 at 12:07 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> @@ -1095,9 +1098,11 @@ static void pp_buffer_stderr(struct
>> parallel_processes *pp, int output_timeout)
>> static void pp_output(struct parallel_processes *pp)
>> {
>> int i = pp->output_owner;
>> -
Stefan Beller wrote:
> When the callers of parallel processing machine are sloppy with their
> messages, make sure the output is terminated with LF after one child
> process is handled.
Why not always add \n here?
That would make callers simpler and would make it easier for callers to
know what
Stefan Beller writes:
> @@ -1095,9 +1098,11 @@ static void pp_buffer_stderr(struct parallel_processes
> *pp, int output_timeout)
> static void pp_output(struct parallel_processes *pp)
> {
> int i = pp->output_owner;
> - if (pp->children[i].state == GIT_CP_WORKING &&
> - pp->c
When the callers of parallel processing machine are sloppy with their
messages, make sure the output is terminated with LF after one child
process is handled. This will not mess with the internal state of the
output, i.e. after all messages for one child process are process
including the callbacks
8 matches
Mail list logo
